superagent icon indicating copy to clipboard operation
superagent copied to clipboard

[proposal] Only using node testing tools

Open jimmywarting opened this issue 2 years ago • 3 comments

Describe the feature

I would like (if you agree) to refactor the spec/test to only using node:assert and possible get rid of any outdated dependency.

Checklist

  • [x] I have searched through GitHub issues for similar issues.
  • [x] I have completely read through the README and documentation.

jimmywarting avatar Aug 24 '23 20:08 jimmywarting

I have not been such a huge fan of things such as res.text.should.equal('{"name":"hal 5000"}');

should pollutes global built in prototypes chain with things you believe are part of the package when it is in fact not.

jimmywarting avatar Aug 24 '23 20:08 jimmywarting

Definitely down to use built-in Node test stuff, either that or Ava like we did with https://github.com/breejs/bree

titanism avatar Aug 24 '23 21:08 titanism

I prefer dependency free stuff. now that NodeJS have also a built in test runner also node:test and also a node:assert, then i have stop installing any additional dependencies.

the latest version of node testing tools have really grown to be something 👌

jimmywarting avatar Aug 24 '23 21:08 jimmywarting