FileTest icon indicating copy to clipboard operation
FileTest copied to clipboard

Published 20 hours ago • verified publisher icon ladislav-zezula

UI usability improvements

Open diversenok opened this issue 11 months ago • 1 comments

This pull request fixes two minor UI issues:

  1. If the user makes a typo when trying to open a file by ID (for example, by providing the wrong number of digits), FileTest aborts processing (returning NULL handle) while still reporting STATUS_SUCCESS. This behavior can be very confusing, so I added an indication for incorrect input.
  2. Querying extended attributes on a file that doesn't have them is supposed to display an empty list. However, due to an optimization, if NtQueryInformationFile returns FileEaInfo.EaSize as 0, FileTest skips updating the UI. This can result in showing outdated information, so I added an explicit check that clears the list when there are no items to display.

diversenok avatar Mar 29 '24 19:03 diversenok

I made a new branch LZ_ImprovementsUI. Few comments:

  • I reworked the OnQueryEa() function.
  • When there are no extended attributes, NtQueryEaFile returns STATUS_NO_EAS_ON_FILE.

It should be sufficient.

ladislav-zezula avatar Mar 30 '24 20:03 ladislav-zezula