XDM icon indicating copy to clipboard operation
XDM copied to clipboard

Don't rename release names on/after download

Open pannal opened this issue 10 years ago • 6 comments

I'd like to have the release names as they are returned by the indexers. E.g. Moviename.Quality.Type-GROUP instead of renaming those automatically to Moviename (Year) (already in the downloader).

An option for that would be great.

pannal avatar Feb 27 '14 18:02 pannal

It's related to this I think https://github.com/lad1337/XDM-main-plugin-repo/issues/14

schumi2004 avatar Feb 27 '14 18:02 schumi2004

Yes it is. I'd like to be able to customize how the folder names are generated aswell as how the file names are generated. I'd also be happy with just having the option to disable the automatic renaming.

pannal avatar Feb 27 '14 18:02 pannal

@pannal nope ... there was a reason i identified it as de.lad1337.tv.simplemover

i can make all the enhancements but there is a reason why its all plugin based, and partially decentralized

i'll have to see when i have the time for it, sorry guys :/

lad1337 avatar Feb 28 '14 01:02 lad1337

Well that means I should create a new class inheriting from yours. That would mean a 99% duplicate though and that's not the purpose of a class. One sane thing you could do: expose a renaming flag or wrap the renaming process into an overridable method so one could inherit the class, or expose it as a config option.

I could fork, fix and pull-request if I find the time, though.

Edit: do you support self._config inheritance? Using that I could add the feature to all Downloaders as that's a feature not necessarily bound to a single Downloader.

pannal avatar Feb 28 '14 02:02 pannal

I could fork, fix and pull-request if I find the time, though.

you could do that or you could fork the plugin repo ... delete everything you don't want to support improve the mover plugin(...change the identifier!) and add your repo to the wiki(optional)

One sane thing you could do: expose a renaming flag or wrap the renaming process into an overridable method so one could inherit the class,

all plugins are like this ... based from the plugin base classes with few "stub" methods i dont know if i understand you correctly so i am sorry if you know the following: "my class" is not in the core of XDM its completely replaceable with other plugins from other repos / people

XDM is just a some kind of framework with "crons" and a plugins system and updater technically its nothing more (the range of operation is limited) ... and my idea was create these "simple" plugins to show people how to use the XDM framework

the .py in question is here https://github.com/lad1337/XDM-main-plugin-repo/blob/master/Episode%20Mover/EpisodeMover.py (note the other repo)

if you get all this and just mean that the plugins would repeat code because they are so similar: currently there is no way of extending other plugins ... i don't think it would work with simple inheritance i thought about it a lot and haven't found a nice way. And creating a flag / overridable method inside a plugin would be a bold move ... it would be a "framework" inside a framework and i have a hard time keeping one at work :/

lad1337 avatar Feb 28 '14 03:02 lad1337

Are you sure that's where you want to go with this project? Enabling everyone to fork your plugin repo to make minimal changes to their likings and release those as separate plugins? That could lead to some serious fragmentation aswell as "which of those 10 MovieMover plugins should I take now ..." for new and current users.

I think you should at least consider cherry picking simple core features from other plugin repos into your default plugins.

pannal avatar Feb 28 '14 14:02 pannal