Luke Craig

Results 45 comments of Luke Craig

Finished with merge by #1194!

Unfortunately I haven't had time to work on this in a while and likely won't in the near term. Feel free to take over @hsiam261. I believe that will require...

@AndrewFasano nice issue. ## Addressing the API issue at hand I think this is worth doing. I like a lot of the subsystems you have identified. I think we could...

> If we stop passing CPUState around and switch to first_cpu (probably implicitly), we're limiting ourselves to single-core guests - if we move to TCG plugins and qemu 7 we'll...

@MarkMankins which function does this conversion? It would be fairly easy to add.

I tried getting this workflow working several times and on each of the runs the whl file was missing. https://github.com/panda-re/panda/actions/runs/8035190848/job/21947562763#step:5:11 This version looks like we've changed to release assets and...

I also get the whl file locally. I'm not quite sure what the issue is.

@AndrewQuijano now that the whl is small I think that would be fine.

> We should avoid having 3 separate places where we install a python package. ❤️

I think this isn't passing tests for unrelated reasons. @AndrewQuijano I will merge this if you think it's ready.