labwc icon indicating copy to clipboard operation
labwc copied to clipboard

[wip] src/osd.c: Add preview outlines

Open Consolatis opened this issue 2 years ago • 1 comments

outlines

Missing:

  • [ ] use some theme defined color for the outlines
  • [ ] use some theme defined width of the outlines
  • [ ] use some config setting to enable / disable the outlines
  • [ ] do we want this in the first place?

Consolatis avatar Jul 04 '22 18:07 Consolatis

Awesome!

heroin-moose avatar Jul 04 '22 22:07 heroin-moose

This would be nice :)

Just throwing an idea out there - would it be difficult to temporarily render the whole window on top, rather than just the outline? I think to me that would be more appealing visually, just a personal preference though.

jlindgren90 avatar Aug 13 '22 17:08 jlindgren90

Agree. Window preview is the way to go. We supported this before scene-graph and it was nice. Consolatis drafted a PR with the “current”window-node moved to the front and an anchor-pointer to remember where it should go back if not chosen. From memory, the edge-cases were a bit troublesome (like windows closing whilst alt-tabbing)

johanmalm avatar Aug 13 '22 18:08 johanmalm

Windows closing while alt-tabbing was fine (AFAIR). The issue was mainly with minimized windows. If anybody wants to take over this one or #307 go ahead, I might not work on these for the next month or two.

Could rebase #307 to fix the merge conflicts before somebody else takes over, just throw me a message in that case.

Consolatis avatar Aug 13 '22 20:08 Consolatis