pylsl icon indicating copy to clipboard operation
pylsl copied to clipboard

Packaging improvements

Open mscheltienne opened this issue 1 year ago • 4 comments

Hi @cboulay! I see that you pushed quite a few nice changes. I have a couple of questions and tips for the packaging. I now see:

https://github.com/labstreaminglayer/pylsl/blob/fb0ae2ed8a0b6eab3b373a1d614e557ab04c7eec/pyproject.toml#L67-L68

Accompagnied with attempts to re-target wheels on windows 32 and 64. Unless mistaken, you are not building and packaging liblsl within pylsl, thus you should have a source distribution and a single binary distribution pylsl-**-py3-none-any.whl. Overall, you should be able to get rid of setup.py entirely and since you reverted to setuptools, specify the following pyproject.toml:

[build-system]
build-backend = 'setuptools.build_meta'
requires = ['setuptools >= 64.0.0']

...

[tool.setuptools]
include-package-data = false

[tool.setuptools.packages.find]
exclude = ['test']
include = ['src/pylsl*']

mscheltienne avatar Dec 13 '24 09:12 mscheltienne