liblsl-Matlab icon indicating copy to clipboard operation
liblsl-Matlab copied to clipboard

Move to MATLAB plugin or Liblsl release

Open arnodelorme opened this issue 10 months ago • 1 comments

Maintaining a separate repo creates all kinds of tracking problems. This code should be included in the MATLAB viewer or in the folder for the liblsl repo. @chkothe @cboulay

arnodelorme avatar Feb 17 '25 22:02 arnodelorme

There are some problems with including it in the liblsl repo.

  1. What about the other language bindings? Python, Rust, C-Sharp, Java, etc.?
  2. The liblsl repo is in the sccn org so it's harder to grant permissions to someone who wants to admin one of the bindings (being separate has worked out well for XDF which has community support beyond just me).
  3. Putting them in the same repo implies compatibility that isn't implied by being in separate repos.

Continued compatibility between all the language bindings and the core library would be great, but is somewhat impossible. What if someone submits a PR to fix something in liblsl C++ code but this person has no knowledge of Java, or they don't have a Matlab license? Do we merge the PR then let the language binding in the same repo desync with liblsl? Do we reject the PR until they fix all the language bindings too, even if that means they have to buy a Matlab license?

I have no objection to merging liblsl-Matlab and App-MatlabViewer, but I would move the latter into here instead of vice versa. liblsl-Matlab is higher priority. This would be similar to pylsl which has a viewer as an example.

cboulay avatar Feb 18 '25 03:02 cboulay