liblsl-Csharp icon indicating copy to clipboard operation
liblsl-Csharp copied to clipboard

Incorrect reference to info-object

Open jonashogstrom opened this issue 3 years ago • 2 comments

https://github.com/labstreaminglayer/liblsl-Csharp/blob/a1f2a0c7f15d4fbf64f197e58ba027b48d79289b/examples/HandleMetaData/HandleMetaData.cs#L47

It seems as the linked line should reference the local variable "inf" and not "info". I suggest splitting the inspection of the stream info into a separate method to make it clear that the two sections of code is independent.

jonashogstrom avatar May 18 '21 21:05 jonashogstrom

Or rename inf to inletInfo to distinguish it from info which is the StreamInfo object used to create the outlet. The have identical information on the insides, of course. I would prefer this to adding a separate method as the example programs obey a kind of template that is standard across all the different language wrappers.

dmedine avatar May 19 '21 01:05 dmedine

Renaming the variable to make it easier to tell then apart makes sense.

jonashogstrom avatar May 19 '21 05:05 jonashogstrom