echo icon indicating copy to clipboard operation
echo copied to clipboard

Cannot read request body after ctx.Bind

Open hayashikun opened this issue 4 months ago • 3 comments

Issue Description

I want to get the request body in httpErrorHandler, but I can't. Once a request body is read by ctx.Bind, it cannot be read afterward.

To read again after reading, the ReaderCloser must be set, but DefaultBinder#BindBody does not do this.

https://github.com/labstack/echo/blob/754479694694f6d0bd280d453c10d63348e4e3b7/middleware/body_dump.go#L72

What is the best way to do this?

Checklist

  • [x] Dependencies installed
  • [x] No typos
  • [x] Searched existing issues and docs

Expected behavior

Can read the request body after ctx.Bind or in httpErrorHandler

Actual behavior

Cannot read the request body after ctx.Bind

Steps to reproduce

Working code to debug

body1 := ctx.Request().Body
buf1, err := io.ReadAll(body1)
if err == nil {
	println("before: " + string(buf1))
}
ctx.Request().Body = io.NopCloser(bytes.NewBuffer(buf1))

bindErr := ctx.Bind(req)

body2 := ctx.Request().Body
buf2, err := io.ReadAll(body2)
if err == nil {
	println("after: " + string(buf2))
}
ctx.Request().Body = io.NopCloser(bytes.NewBuffer(buf2))

return bindErr

When a POST request is sent with {"aaa": "hoge"}, the following log is output

before: {"aaa": "hoge"}
after:

Version/commit

v4.12.0

hayashikun avatar Oct 03 '24 07:10 hayashikun