echo icon indicating copy to clipboard operation
echo copied to clipboard

Returning an open file on Context#FormFile

Open pafuent opened this issue 4 years ago • 2 comments

Now Context#FormFile returns the file descriptor obtained from Go net/http/request, which is already open. In the current implementation that file were closed by Echo, forcing the caller to reopen the file. Of course, from now it's responsability of the caller to close it.

Fixes #1688

pafuent avatar Nov 23 '20 04:11 pafuent

Codecov Report

Merging #1691 (0e01cbb) into master (fdacff0) will decrease coverage by 3.37%. The diff coverage is 100.00%.

:exclamation: Current head 0e01cbb differs from pull request most recent head 98958a2. Consider uploading reports for the commit 98958a2 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1691      +/-   ##
==========================================
- Coverage   90.22%   86.84%   -3.38%     
==========================================
  Files          31       29       -2     
  Lines        2773     2068     -705     
==========================================
- Hits         2502     1796     -706     
- Misses        173      174       +1     
  Partials       98       98              
Impacted Files Coverage Δ
context.go 88.11% <100.00%> (+0.92%) :arrow_up:
middleware/key_auth.go 66.66% <0.00%> (-29.89%) :arrow_down:
middleware/redirect.go 85.00% <0.00%> (-15.00%) :arrow_down:
middleware/proxy.go 60.97% <0.00%> (-5.70%) :arrow_down:
middleware/static.go 67.16% <0.00%> (-2.84%) :arrow_down:
middleware/jwt.go 77.89% <0.00%> (-1.92%) :arrow_down:
middleware/slash.go 90.69% <0.00%> (-0.61%) :arrow_down:
echo.go 91.53% <0.00%> (-0.11%) :arrow_down:
middleware/timeout.go
middleware/rate_limiter.go
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fdacff0...98958a2. Read the comment docs.

codecov[bot] avatar Nov 23 '20 04:11 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed within a month if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jan 09 '22 00:01 stale[bot]

closing at the moment

aldas avatar Mar 06 '24 19:03 aldas