backend.ai-webui icon indicating copy to clipboard operation
backend.ai-webui copied to clipboard
verified publisher icon lablup

feat(FR-1726): Auto-populate ENV variables based on selected Inference Runtime Variant

Open agatha197 opened this issue 1 month ago • 2 comments

resolves FR-1726

Enhance Environment Variable Management for Model Services

This PR adds runtime-specific environment variable configurations and improves the environment variable form component with the following features:

  1. Added support for runtime-specific environment variables with predefined configurations for vllm, sglang, and nim runtimes
  2. Implemented autocomplete for environment variable names based on the selected runtime
  3. Added dynamic placeholders for environment variable values based on the selected variable
  4. Created exception for NGC_API_KEY to prevent sanitization despite matching sensitive patterns
  5. Improved form validation and filtering of empty environment variables
  6. Added translations for all new environment variable placeholders across multiple languages

These changes make it easier for users to configure model services with the correct environment variables for each runtime type, providing better guidance through placeholders and autocomplete suggestions.

image.png

image.png

image.png

Checklist:

  • [x] Documentation
  • [ ] Minium required manager version
  • [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
  • [ ] Minimum requirements to check during review
  • [x] Test case(s) to demonstrate the difference of before/after

agatha197 avatar Nov 27 '25 10:11 agatha197

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

agatha197 avatar Nov 27 '25 10:11 agatha197

Coverage report for ./react

St.:grey_question:
 Category Percentage Covered / Total
🔴 Statements
4.21% (-0.03% 🔻)
 496/11794
🔴 Branches
3.67% (+0.01% 🔼)
 302/8235
🔴 Functions
2.53% (-0.02% 🔻)
 92/3631
🔴 Lines
4.18% (-0.03% 🔻)
 482/11536
Show new covered files 🐣
St.:grey_question:
 File Statements Branches Functions Lines
🔴
... / useVariantConfigs.ts
 0% 100% 0% 0%
Show files with reduced coverage 🔻
St.:grey_question:
 File Statements Branches Functions Lines
🔴
... / EnvVarFormList.tsx
16.33% (-11.26% 🔻)
16.33% (-14.44% 🔻)
14.81% (-10.19% 🔻)
15.22% (-10.71% 🔻)

Test suite run success

145 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 2b2f963c260a2bebf807332e01d627f7679aeea0

github-actions[bot] avatar Nov 27 '25 10:11 github-actions[bot]