backend.ai-webui icon indicating copy to clipboard operation
backend.ai-webui copied to clipboard

feat: open folder explorer in vfolder table component and session launcher

Open ironAiken2 opened this issue 1 year ago • 4 comments

This PR allows folder explorer to be opened in the vfolder tablecomponent and session launcher review step.

Changes

  • Added functionality to open folder explorer when clicking on folder names in the VFolder table
  • Updated the VFolder table to display folder names as clickable links
  • Modified the alias map structure to include folder ID and name alongside the alias
  • Adjusted the session launcher page to handle the updated alias map structure
  • Added a new column in the session launcher page to display folder names as clickable buttons
  • Integrated the useFolderExplorerOpener hook to handle folder opening functionality
  • Updated the sidebar menu to include a 'serving' key for the service path

What to look for in testing

  • The data structure for aliasMap has changed, so you need to make sure that the functionality of your existing session launcher and service launcher work correctly.
    1. Launching and deleting sessions
    2. Whether aliases for vfolders are applied correctly
    3. Whether folder explorer works properly in session launcher and vfolder table
    4. When creating and modifying services, you need to ensure that vfolder explorer works properly and that aliases are applied correctly.

Checklist:

  • [x] Mention to the original issue
  • [ ] Documentation
  • [ ] Minium required manager version
  • [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
  • [ ] Minimum requirements to check during review
  • [ ] Test case(s) to demonstrate the difference of before/after

ironAiken2 avatar Oct 07 '24 09:10 ironAiken2

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Oct 07 '24 09:10 graphite-app[bot]

  • #2738 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ironAiken2 and the rest of your teammates on Graphite Graphite

ironAiken2 avatar Oct 07 '24 09:10 ironAiken2

Coverage report for ./react

St.:grey_question:
Category Percentage Covered / Total
🔴 Statements
5.41% (+0% 🔼)
348/6431
🔴 Branches
4.86% (-0.01% 🔻)
218/4487
🔴 Functions
3.16% (-0% 🔻)
67/2123
🔴 Lines
5.3% (+0% 🔼)
333/6282

Test suite run success

93 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from 7e72253bc6476686dedcadbb85a156c39d565429

github-actions[bot] avatar Oct 08 '24 08:10 github-actions[bot]

After reloading the page, all alias information disappears.

There seems to be some logic missing to add the existing settings on refresh.

https://app.graphite.dev/github/pr/lablup/backend.ai-webui/2738/feat-open-folder-explorer-in-vfolder-table-component-and-session-launcher#comment-PRRC_kwDOCRTcws5rNm_S

ironAiken2 avatar Oct 14 '24 04:10 ironAiken2