Add query parameter handling in ServiceLauncherPageContent
This pull request introduces the capability to handle optional query parameters in the ServiceLauncherPageContent component. The new parameters include modelMountDestination, modelDefinitionPath, and extraMounts, which are parsed and integrated into the component's logic. This enhancement allows the component to dynamically adjust its behavior based on the provided query parameters, thus improving flexibility and configurability.
how to test
- For
Mount Destination For Model Folder, setmodelMountDestinationquery params. e.g)/service/start?modelMountDestination=/models - For
Model Definition File Path, setmodelDefinitionPathquery params. e.g)/service/start?modelMountDestination=/models&modelDefinitionPath - For
Additional Mounts, setextraMountsquery params. It is comma-separated. the empty space, double/single quote, hypen will be replaced with empty string (''). e.g)/service/update?extraMounts=66b66ac36fd6431ab0cf9abfc944bb3d,a4bed13753ca4603a197df76e12630db
Checklist: (if applicable)
- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
Your org requires the Graphite merge queue for merging into main
Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @agatha197 and the rest of your teammates on
Graphite
Coverage report for ./react
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.67% | 141/5281 |
| 🔴 | Branches | 2.87% | 101/3515 |
| 🔴 | Functions | 1.54% | 27/1754 |
| 🔴 | Lines | 2.55% | 132/5180 |
Test suite run success
51 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 6fbdbfa2683198cfbb97bac030ed3c60d32dea69
Merge activity
- Jul 8, 8:27 PM EDT:
yomybabyadded this pull request to the Graphite merge queue. - Jul 8, 8:29 PM EDT:
yomybabymerged this pull request with the Graphite merge queue.