backend.ai-webui
backend.ai-webui copied to clipboard
fix: remove comments on config values
This PR Resolves #2382 Issue. (and minor fix on summary page's alert margin)
Why the bug occurred
Inside the config.toml file, a description of each value is included as a comment. These comments were being read together to prevent the default value from being used even when no value was provided.
Feature
- Remove comments when reading config.toml values
- Adjust the alert margin at the top of the summary page
Checklist: (if applicable)
- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
Coverage report for ./react
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π΄ | Statements | 2.71% | 118/4350 |
| π΄ | Branches | 2.93% | 87/2968 |
| π΄ | Functions | 1.33% | 19/1430 |
| π΄ | Lines | 2.67% | 114/4268 |
Test suite run success
32 tests passing in 4 suites.
Report generated by π§ͺjest coverage report action from 20d0818e5055a95c08205f6819a5763b0763026b
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @ironAiken2 and the rest of your teammates on
Graphite