backend.ai-webui icon indicating copy to clipboard operation
backend.ai-webui copied to clipboard

fix: remove comments on config values

Open ironAiken2 opened this issue 1 year ago β€’ 2 comments

This PR Resolves #2382 Issue. (and minor fix on summary page's alert margin)

Why the bug occurred

Inside the config.toml file, a description of each value is included as a comment. These comments were being read together to prevent the default value from being used even when no value was provided.

Feature

  • Remove comments when reading config.toml values
  • Adjust the alert margin at the top of the summary page

Checklist: (if applicable)

  • [ ] Mention to the original issue
  • [ ] Documentation
  • [ ] Minium required manager version
  • [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
  • [ ] Minimum requirements to check during review
  • [ ] Test case(s) to demonstrate the difference of before/after

ironAiken2 avatar Apr 29 '24 04:04 ironAiken2

Coverage report for ./react

St.:grey_question:
Category Percentage Covered / Total
πŸ”΄ Statements 2.71% 118/4350
πŸ”΄ Branches 2.93% 87/2968
πŸ”΄ Functions 1.33% 19/1430
πŸ”΄ Lines 2.67% 114/4268

Test suite run success

32 tests passing in 4 suites.

Report generated by πŸ§ͺjest coverage report action from 20d0818e5055a95c08205f6819a5763b0763026b

github-actions[bot] avatar Apr 29 '24 04:04 github-actions[bot]

  • #2383 Graphite πŸ‘ˆ
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ironAiken2 and the rest of your teammates on Graphite Graphite

ironAiken2 avatar May 13 '24 09:05 ironAiken2