backend.ai-webui icon indicating copy to clipboard operation
backend.ai-webui copied to clipboard

Let's enable button only if user input is valid on every button inside panels in Import & Run page.

Open lizable opened this issue 2 years ago • 0 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 기능 요청이 특정 문제에 연관된 것이라면 여기에 그 문제를 설명해주세요. For users, when any button has a ripple effect on hover or click, then they may easily think there would be an operation occur (such as open dialog or modal, etc.) on click event. Currently click event only reacts when input is not empty, which is likely to bring unintended confusion. And there's a "ripple event" around every button on Import & Run page regardless of inputs.

Describe the solution you'd like A clear and concise description of what you want to happen. 어떤 기능이 있으면 좋겠는지 자세히 설명해주세요. Let's enable the button only if the user input is valid. if not(like empty or wrong), disabling the button would be enough.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. 혹시 다른 대안들을 생각해본 적이 있다면 함께 적어주세요. If disabling the button seems to be too strict, displaying both error messages on snackbar and near input field would be the alternative way to inform user input is wrong.

Additional context Add any other context or screenshots about the feature request here. 기능 요청에 대해 보다 잘 이해할 수 있는 다른 맥락을 기술해주세요. This issue has been raised during code-reviewing and E2E tests on #1359.

Screenshots

import_run_page_buttons

lizable avatar Jul 25 '22 07:07 lizable