backend.ai-webui icon indicating copy to clipboard operation
backend.ai-webui copied to clipboard

Typing shadowRoot of LitElement

Open Jaewoook opened this issue 3 years ago • 0 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 기능 요청이 특정 문제에 연관된 것이라면 여기에 그 문제를 설명해주세요. Currently, LitElement's shadowRoot property is typed as any in entire project. So it makes all variables from shadowRoot's result type to any. As a result, possible type error could occur anytime and code are not type-safe. (TypeScript backend could not type-check properly)

I think we need to remove shadowRoot: any and make type-safe code.

This issue is sub-task of #1354

Describe the solution you'd like A clear and concise description of what you want to happen. 어떤 기능이 있으면 좋겠는지 자세히 설명해주세요.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered. 혹시 다른 대안들을 생각해본 적이 있다면 함께 적어주세요.

Additional context Add any other context or screenshots about the feature request here. 기능 요청에 대해 보다 잘 이해할 수 있는 다른 맥락을 기술해주세요.

image image

type errors when removing shadowRoot: any in src/components/backend-ai-pages.ts

Jaewoook avatar Jul 07 '22 13:07 Jaewoook