backend.ai-webui icon indicating copy to clipboard operation
backend.ai-webui copied to clipboard
verified publisher icon lablup

fix: cluster size slider to be active by cluster mode selection

Open Jaewoook opened this issue 3 years ago • 2 comments

Fixes

  • call updateResourceAllocationPane() on cluster mode selection handler

additional comment:

I think updateResourceAllocationPane() method need code refactoring. The method cause logical confusion, but I didn't do this because I don't know all intent of condition statement and variables behavior.

related issue: #1347

Jaewoook avatar Jul 07 '22 10:07 Jaewoook

I found this below error.

  1. Update resource allocation on the 3rd session page
  2. Set another image on 1st session page
  3. Go to the 3rd page
  4. Then all custom resource allocations are reset.

@Sujin-Kim1 I think it's bit more complex to fix. I'll refactor update resource allocation logic after #1360 done.

Jaewoook avatar Jul 12 '22 03:07 Jaewoook

Fixes

  • call updateResourceAllocationPane() on cluster mode selection handler

additional comment:

I think updateResourceAllocationPane() method need code refactoring. The method cause logical confusion, but I didn't do this because I don't know all intent of condition statement and variables behavior.

related issue: #1347

I agree with your opinion, especially in refactoring updateResourceAllocationPane(). It does too many things at one function which degrades understanding logic inside. Let's create an issue for that and solve it!

lizable avatar Jul 22 '22 08:07 lizable