lablabs
make rke2_kubelet_arg set root-dir by default, as the default is unintuitive
Description
make rke2_kubelet_arg set root-dir by default, as the default is unintuitive. This change better indicates that it matters, and makes the default value explicit.
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
- [x] Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)
How Has This Been Tested?
made the modifications in the rke2 config.yaml and tested if it worked as expected. also rolled out a deployment with this code.
I think it is necessary because I expected that changing the rke2_data_path would result in all the rke2 related data would end up there. I need to change the rke2_data_path because the system I am deploying to has /var on a very small partition. It took me a while to figure out that kubelet still uses the default /var/lib/kubelet path even though the rke2 stuff is somewhere else. I think this change highlights it better, and makes it more obvious that it matters and that there is an implicit default specified.
I think this change might be really helpful to people who need to change the rke2_data_path.
@simonfelding I understand your point but i don't think this Ansible Role should be opinionated on this and to have the default value for kubelet root-dir in the default vars (even though it's the same as the default in RKE2 or Vanilla Kubernetes deployment).
