labgrid
labgrid copied to clipboard
agentwrapper: Bump SSH timeout
Bumps the SSH connection timeout to 30 seconds for the agent wrapper to match the other SSH timeouts
Checklist
- [ ] Documentation for the feature
- [ ] Tests for the feature
- [ ] The arguments and description in doc/configuration.rst have been updated
- [ ] Add a section on how to use the feature to doc/usage.rst
- [ ] Add a section on how to use the feature to doc/development.rst
- [ ] CHANGES.rst has been updated
- [x] PR has been tested
- [ ] Man pages have been regenerated
Codecov Report
Merging #954 (a4be000) into master (dffc61d) will not change coverage. The diff coverage is
100.0%
.
@@ Coverage Diff @@
## master #954 +/- ##
======================================
Coverage 57.1% 57.1%
======================================
Files 150 150
Lines 11199 11199
======================================
Hits 6402 6402
Misses 4797 4797
Impacted Files | Coverage Δ | |
---|---|---|
labgrid/util/agentwrapper.py | 96.5% <100.0%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dffc61d...a4be000. Read the comment docs.
The idea behind the lower timeout for the agent was that the exporter must already be running at this point and that the network connection to an exporter should be reliable.
Did you run into the 5 second timeout?
Yes. Due to many factors, we need a longer delay when connecting to the exporters (internal networking, multiple places per exporter, etc.). The 30 seconds on the normal connection timeout appears to be sufficient, although ideally it would be globally adjustable which I'm working on proposal to do that which I'll submit as a PR soon.
#958 effectively does the same thing, but is my attempt to make it globally controlled. If you would prefer submitting that instead, that is fine with me
Superseded by #958