labgrid icon indicating copy to clipboard operation
labgrid copied to clipboard

path too long error fix

Open danielschickmunit opened this issue 3 years ago • 5 comments

Fixes #948

changes the names for the temporary file_paths from labgrid-ssh-tmp- to lg-ssh- and labgrid-connection- to lg-con-

in order to be compatible with MacOS and its longer tempdir-path

danielschickmunit avatar Jul 04 '22 08:07 danielschickmunit

Is this the only change needed for MacOS? So far, we only support Linux and I wouldn't make want to make MacOS a supported platform as that could limit us in the future.

jluebbe avatar Jul 04 '22 09:07 jluebbe

as far as i can tell it's the only thing that has to change, but i can't tell if all features of the client will work, I'm only using the labgrid-client on MacOS and the rest will run on linux machines

for the sake of completeness I also had to install the labgrid python package via python3 -m pip install .

the features that i'm using for the client on MacOS is ssh to the exporter and ser2net connection to the dut

it's understandable that only support for linux is desired. For the rest I use the docker-images that I build using the dockerfile

I mostly use MacOS natively to be able to debug labgrid via vscode but I could also attach the debugger to the container

danielschickmunit avatar Jul 04 '22 11:07 danielschickmunit

FWIW this also happens on Linux, so its not macOS exclusive. Can you fix the DCO by adding a signed off by?

Emantor avatar Jul 22 '22 14:07 Emantor

Codecov Report

Merging #949 (82b9542) into master (dffc61d) will not change coverage. The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master    #949   +/-   ##
======================================
  Coverage    57.1%   57.1%           
======================================
  Files         150     150           
  Lines       11199   11199           
======================================
  Hits         6402    6402           
  Misses       4797    4797           
Impacted Files Coverage Δ
labgrid/util/ssh.py 92.4% <ø> (ø)
labgrid/driver/sshdriver.py 58.3% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dffc61d...82b9542. Read the comment docs.

codecov[bot] avatar Jul 22 '22 14:07 codecov[bot]

@Emantor added a signed off by ✅

danielschickmunit avatar Jul 25 '22 12:07 danielschickmunit