labgrid icon indicating copy to clipboard operation
labgrid copied to clipboard

Coordinator state persistence

Open benjamb opened this issue 3 years ago • 1 comments

As things are, restarting the coordinator will result in any locks or reservations that were being tracked to be lost (despite the fact that some of this state may have been written to disk (e.g. locks in places.yaml)).

While easy enough to avoid this by waiting for a period where no devices are in use, it would be ideal if I could upgrade to a new container image without causing this state to be lost entirely.

I see this topic was touched upon briefly as part of https://github.com/labgrid-project/labgrid/issues/293#issuecomment-507594892, but I'm unsure if this particular comment implies that this behaviour is by design.

benjamb avatar Jun 29 '22 16:06 benjamb

This is by design, as during a coordinator restart we would miss all events from the exporters happening during the restart, which could lead to an inconsistent state on any client. Changing that without a different communication infrastructure seems difficult.

jluebbe avatar Jun 30 '22 07:06 jluebbe

@benjamb Is this something you strictly need? If not, I'd like to close this.

Bastian-Krause avatar Aug 31 '22 08:08 Bastian-Krause

@jluebbe Thanks for your response.

@Bastian-Krause This is not strictly required at this time.

benjamb avatar Sep 07 '22 11:09 benjamb

Okay, I'm closing this for now. If you consider working on a solution for this in the future, please reopen this issue beforehand, so we can discuss the design.

Bastian-Krause avatar Sep 09 '22 07:09 Bastian-Krause