labgrid
labgrid copied to clipboard
shelldriver: fixes and improvements
Description
- shelldriver: make run wrapper injecting more reliable
- shelldriver: make kernel silencing more reliable
- shelldriver: fix missing kernel silencing on password less consoles
- shelldriver: make post_login_settle_time generally available
Checklist
- [x] PR has been tested
Cc: @JoshuaWatt
Codecov Report
Attention: Patch coverage is 8.10811%
with 34 lines
in your changes are missing coverage. Please review.
Project coverage is 62.6%. Comparing base (
69fd553
) to head (65d0269
). Report is 295 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
labgrid/driver/shelldriver.py | 8.1% | 34 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #945 +/- ##
========================================
- Coverage 62.7% 62.6% -0.2%
========================================
Files 159 159
Lines 11658 11687 +29
========================================
+ Hits 7319 7321 +2
- Misses 4339 4366 +27
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Tested this with a Turris Omnia and it fixes the ShellDriver issues as described.
While this fixes "real world" devices, it break the QEMU driver for me, muting all shell output. I'll investigate further and give more details once I got them.
@Bastian-Krause thanks a lot for a review, really appreciate it! I'll rebase and retest soon.