labgrid
labgrid copied to clipboard
Dockerfile: Add dev-requirements dependencies to client image
Description Add dev-requirements and lib onewire to the labgrid-client image
- [x] PR has been tested
Codecov Report
Merging #740 (cab413f) into master (b36a9cf) will decrease coverage by
0.0%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #740 +/- ##
========================================
- Coverage 58.6% 58.6% -0.1%
========================================
Files 133 133
Lines 9476 9476
========================================
- Hits 5560 5559 -1
- Misses 3916 3917 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| labgrid/util/agentwrapper.py | 96.5% <0.0%> (-1.2%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update b36a9cf...cab413f. Read the comment docs.
With dev-requirements, it will also pull in the full crossbar, yapf and the documentation tools, which should not be needed for a client only container. Is the additional size so small that this doesn't hurt?
Otherwise we could add a "full-client-requirements.txt" and use that for the container.
With dev-requirements, it will also pull in the full crossbar, yapf and the documentation tools, which should not be needed for a client only container. Is the additional size so small that this doesn't hurt?
Otherwise we could add a "full-client-requirements.txt" and use that for the container.
I see your proposal for at full-client-requirements.txt as a good solution, not so much because of disk space but it think it will make it easier to see what dependencies are required where. I will close this PR and make that in a new one, when time allows. Anyone who disagree ?
With dev-requirements, it will also pull in the full crossbar, yapf and the documentation tools, which should not be needed for a client only container. Is the additional size so small that this doesn't hurt? Otherwise we could add a "full-client-requirements.txt" and use that for the container.
I see your proposal for at full-client-requirements.txt as a good solution, not so much because of disk space but it think it will make it easier to see what dependencies are required where. I will close this PR and make that in a new one, when time allows. Anyone who disagree ?
Sounds good to me.
@krevsbech If this is still relevant for you, we could now move to the "dev" extra easily.