labgrid
labgrid copied to clipboard
Switch to pyproject.toml, relax dependency versions
Description We decided to move from setup.{py,cfg}/requirements to pyproject.toml and relax the dependency versions.
Note: took a few commits from #891
Checklist
- [x] PR has been tested
Closes #891
Codecov Report
Base: 62.6% // Head: 62.6% // No change to project coverage :thumbsup:
Coverage data is based on head (
dff2aa3
) compared to base (7a0cb9b
). Patch has no changes to coverable lines.
Additional details and impacted files
@@ Coverage Diff @@
## master #1001 +/- ##
======================================
Coverage 62.6% 62.6%
======================================
Files 151 151
Lines 11383 11383
======================================
Hits 7127 7127
Misses 4256 4256
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
- [x] coverage decrease is unexpected, needs investigation
- [x] coverage decrease is unexpected, needs investigation
pytest-cov only works in editable mode: https://github.com/pytest-dev/pytest-cov/issues/388
So force-pushed:
- re-added the
-e
inpip install -e .[dev]
in GitHub actions workflow to collect coverage correctly - fixed typo in a commit message
Force-pushed:
- rebased on master
- fixed typos in commit messages
- dropped unnecessary
pip install
statements from the CI workflow and documentation - extended commit message with https://github.com/pypa/pip/issues/4145
- re-add/update documentation/warning in case other pyserial version than https://github.com/labgrid-project/pyserial/releases/tag/v3.5.0.1 are used (maybe we should allow the previous v3.4.0.1 version for non-pip installs as well?)
Rebased.
Discussed this @Bastian-Krause: As the installation time of 1-2 hours in CI is not acceptable, we should split the move to pyproject.toml from the dependency version changes. Also, we should avoid self-dependencies in the extras, as the failure mode of older pip versions (such as the one in debian stable) in this case is very confusing.
Force-pushed:
- rebased
- dropped dependency version bumps
- dropped dependency version relaxations, use pinned versions instead (like we did before)
- dropped tox workarounds to force new pip
- dropped commit: crossbar: config: set user_timeout in default config (since we don't bump crossbar's version)
- dropped release doc adjustment regarding dependency version relaxations
- added commit: tox: pass TERM environment variable to test env
- added commit: debian: use recent pip, drop obsolete setuptools requirement
- quoted pip installs with extras in the docs (due to square brackets)
Hm, this seems to break coverage. No idea why, yet.
Edit: coverage is also broken on master, so that's unrelated.
Hm, this seems to break coverage. No idea why, yet.
Edit: coverage is also broken on master, so that's unrelated.
It worked in https://github.com/labgrid-project/labgrid/actions/runs/3345404124/jobs/5540884396, so perhaps the update to pytest-cov-4.0.0 fixed it.
Hm, this seems to break coverage. No idea why, yet. Edit: coverage is also broken on master, so that's unrelated.
It worked in https://github.com/labgrid-project/labgrid/actions/runs/3345404124/jobs/5540884396, so perhaps the update to pytest-cov-4.0.0 fixed it.
See https://github.com/labgrid-project/labgrid/pull/1029#issuecomment-1300692866.
Rebased (due to previous conflicts caused by #1032).
Thanks a lot!