django-cognito-jwt icon indicating copy to clipboard operation
django-cognito-jwt copied to clipboard

Support custom auth header and user_or_create_function

Open RenderCoder opened this issue 7 years ago • 2 comments

It is not everyone will write their own UserManager I think (also am I), so it is possible to support user to change their custom user_or_create_function and auth header.

Add:

  • custom user_or_create_function support
  • custom auth header support Optimize:
  • the README document content, user can easy to use this tool

RenderCoder avatar May 06 '18 15:05 RenderCoder

Thanks for this PR!

Could you have a look at:

  • the test suite - all tests fail at the moment
  • declare 'defaults' for the settings you add, so that existing installations can safely upgrade and configuration is not needed when running in default mode?
  • avoid the use of eval() - can you find another way? Eval() is considered bad practise

pimvernooij avatar May 07 '18 15:05 pimvernooij

Thanks, I'll learn about it.

RenderCoder avatar May 21 '18 05:05 RenderCoder