Pavel Labath

Results 19 comments of Pavel Labath

> Well, my logic was that it's better to return something than nothing, For a simple variable query, it might be okay since you kind of see the full name...

> > I think we may want to implement this in a slightly different matter: find the unique definition DIE for the given type (we use that concept when parsing...

The composite formats are not an *un*reasonable idea, but I can't help but wonder if we even need to touch the generic data formatter infrastructure. I mean we already have...

> Another aside: Does anyone know why the [libstdc++ `std::__cxx11::string` summaries](https://github.com/llvm/llvm-project/blob/802fa92aee3565768887615108aa3e924d4e0fc7/lldb/source/Plugins/Language/CPlusPlus/LibStdcpp.cpp#L240-L358) weren't using the string summary? They were initially added in [D13964](https://reviews.llvm.org/D13964), but it doesn't provide a reason to do...

It's not just lldb -- llvm in general likes to absorb things into its repository. Although I don't really agree with the practice, I can't deny the practicality of not...

Let's back up a bit. Before this patch, both the ValueObject class and the "frame var" command treated references essentially as pointers (in the example, `xp` is a pointer to...

I can believe that this behavior is undesirable. Like I said, I totally understand *why* you did this. It's the *how* I have a problem with. I don't believe the...

Regarding the vector summary example, it looks like that there's still a lot of room for improvement there. This is what I get before this patch: ``` (lldb) v v...

Thanks for your understanding. Here's a revert PR (https://github.com/llvm/llvm-project/pull/114831). I'll submit it after the CI runs. Would you like to create an RFC thread to continue this discussion?