librascal icon indicating copy to clipboard operation
librascal copied to clipboard

Add running examples to CI

Open mastricker opened this issue 5 years ago • 2 comments

Some of the examples did not work when I checked them. Since this is probably the first place where people look at our baby when they want to try something out we should ensure that they work.

Putting @rosecers since you seem to be the driving force behind the examples/tutorials and that could be included? Feel free to object.

mastricker avatar Oct 18 '19 13:10 mastricker

Very good idea :+1:

I would also take the occasion to cleanup the examples, and maybe reduce their number. For example, I think the playground.cc, test_sph_harm_poles.cc and maybe others files should go to code heaven.

Luthaf avatar Oct 18 '19 13:10 Luthaf

playground is literally what it's name is. But it should not reside in examples. Didn't we have that discussion a while ago that we allow a sandbox - at least for a while to try stuff.

But in general, I agree.

mastricker avatar Oct 18 '19 13:10 mastricker