chemiscope icon indicating copy to clipboard operation
chemiscope copied to clipboard

Enable Selective Opacity

Open rosecers opened this issue 4 years ago • 3 comments

  • [x] convert all 2D colormaps to RGBA format
  • [x] disable RGBA format for 3D colormaps until plotly can support

rosecers avatar Aug 26 '20 13:08 rosecers

@Luthaf I've made it through the first pass on the branch feat/rgba. Currently, there are no opacity-affected colormaps, so I included a commented line in src/maps/colorscales.ts to uncomment to demonstrate the new functionality. Thoughts on the structure? If it looks good I'll move ahead with opacity modes.

rosecers avatar Aug 27 '20 15:08 rosecers

Why do you say that this wouldn't work in 3D? seems it's enough to set trace opacity to 0.99999 and then it honors the alpha channel https://github.com/plotly/plotly.js/issues/3492

On Thu, 27 Aug 2020 at 17:11, rosecers [email protected] wrote:

@Luthaf https://github.com/Luthaf I've made it through the first pass on the branch feat/rgba. Currently, there are no opacity-affected colormaps, so I included a commented line in src/maps/colorscales.ts to uncomment to demonstrate the new functionality. Thoughts on the structure? If it looks good I'll move ahead with opacity modes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cosmo-epfl/chemiscope/issues/79#issuecomment-682010968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIREZYIHVZOFVM2GVM4RFTSCZZRBANCNFSM4QLZ77VQ .

ceriottm avatar Aug 27 '20 19:08 ceriottm

I remember that there where some other issues with transparency in 3D with plotly (related to depth buffer & points appearing on top of others), but we can check if the fix would work for us!

Luthaf avatar Aug 28 '20 10:08 Luthaf