cln4rust
cln4rust copied to clipboard
laanwj
Crate that provides an RPC binding from rust code to the c-lightning daemon
This PR is still in its infancy, but this will enable us to work directly with the gossip map of cln in rust. cc @rustyrussell Docs: https://github.com/ElementsProject/lightning/pull/5592/commits/6e4e104dfd0d6adc8b7c84886b077b752bf5dced Signed-off-by: Vincenzo Palazzo
Fixes https://github.com/laanwj/cln4rust/issues/122
I just noted that there is no way to implement an hook with proc macro, so we should solve this
If the plugin crash this code https://github.com/laanwj/cln4rust/blob/master/plugin/src/plugin.rs#L80-L83 cause a panic We should not unwrap but we ok with a failure, something like ```rust let _ = write.flush(); ```
people are using the rpc create just because it is not well documented in the common crate and also because I can do better with the interface. I was thinking...
With the following PR https://github.com/laanwj/rust-clightning-rpc/pull/36 we introduce the macros to register a new notification, and this cause a problem because multiple macros can import the same stuff, so a possible...
I think this part of our codebase https://github.com/laanwj/cln4rust/blob/master/plugin/src/plugin.rs#L260-L284 is causing problems like the one https://github.com/coffee-tools/folgore/issues/25 We should use a library like https://github.com/cloudhead/popol or https://github.com/tokio-rs/mio to await new events
Add better documentation maybe with a rust book can be great for the users
Take the value from the configuration plugin usually inside the init method is painful ```diff + .on_init(&|plugin| -> Value { + plugin.log(LogLevel::Debug, "Custom init method called"); + // FIXME: improve...
- [X] plugin - [ ] plugin_macros