laa-odoo
laa-odoo
> first quick review. > > From a functional POV, I'd > > * have the greyed elements less blurred (closer to what GSheet does?) > * the background less...
in this case you might as well remove the return types from all the formulas, right? having a transient state where you don't know when you develop a formula whether...
if the goal is to gain performance this way, might consider reviewing how the casting function returns the error as well
also in this approach I wonder when you replace that ```typescript throw new EvaluationError(_t("The number of columns must be positive.")); ``` by ```typescript return new EvaluationError(_t("The number of columns must...
> > if the goal is to gain performance this way, might consider reviewing how the casting function returns the error as well > > Any idea ? I only...
> the commit title could point towards the global context in which it is used, which is the Xlsx import if i'm not. mistaken? in fact this concerns the xlsx...
> Is it actually slower ? (for the common case where there are no table references) I exported the large formula dataset to re-import it. With this branch, `convertTableFormulaReferences` is...
done in https://github.com/odoo/o-spreadsheet/pull/4897
thx @LucasLefevre for the suggestions Think should be okay :)
thx @LucasLefevre, Your comments have been taken into account.