Mario Loriedo

Results 270 comments of Mario Loriedo
trafficstars

> LGTM but I dont really have a strong understanding for most of this to accurately review. you need to rebase to pick up the BUD fixes from main. Thanks....

> Should we fix #22411 before 5.1? If we change the location later we might have to consider backwards compatibility problems Absolutely. If we fix #22411 before 5.1 things will...

> Well I mean selecting none as default seems to best option to me. We still default to WSL if nothing is set in containers.conf so it has the same...

> It's usually acceptable practice to comment out the default, and only when that differs specify a value. From that perspective you could have two options a default of wsl...

The PR to support system-wide containers config https://github.com/containers/common/pull/1973

A quick update: I have updated this PR to verify if HyperV is installed using the windows service `vmms` (Hyper-V Virtual Machine Management service) I am testing some changes to...

The PR is updated but we should wait for https://github.com/containers/common/pull/1973 to get vendored in podman in order to merge it. @Luap99 now the creation of `%PROGRAMDATA%\containers\containers.conf.d\99-podman-machine-provider.conf` is skipped if one...

Changes to `containers/common` required by this PR [are now vendored](https://github.com/containers/podman/pull/22638) in `containers/podman`. So it's ok to merge when @n1hility approves it.

> I assume you tested manually both options just to verify no strange msi states? From a code review perspective it looks good just want to double check you verified...

> That sounds ok as long as we aren't distributing the msi. The wsl installation aspect requires it. Also a code signed msi on its own looks like a rogue...