prospectr icon indicating copy to clipboard operation
prospectr copied to clipboard

readASD

Open l-ramirez-lopez opened this issue 4 years ago • 3 comments

further update the readASD function for full compatibility with v8 files (re-organize it)

l-ramirez-lopez avatar Mar 17 '20 18:03 l-ramirez-lopez

Hey @l-ramirez-lopez ,

Just bringing your attention to our asdreader package -- which sole and only purpose is to precisely read ASD files.

Happy to get you on-board if you want to contribute to the package, and use it within prospectr, as I'm concerned of duplicated efforts.

Let me know what you think!

pierreroudier avatar Mar 07 '21 21:03 pierreroudier

Hi Pierre, Sounds a really good idea. I'll be happy to contribute. I see your package appears to have one minor issue reported (which might be not even an actual bug). So please let me know how you think I can contribute.

l-ramirez-lopez avatar Mar 08 '21 15:03 l-ramirez-lopez

I see your package appears to have one minor issue reported (which might be not even an actual bug).

Yes, we have this issue open for about 2 years, because I can't reproduce it. It sounds like a limitation of Windows (hard limit on the number of files open?).

So please let me know how you think I can contribute.

The asdreader package works well as is, so I'm sure you know, most of the work is un-glamourous maintenance! I think something very valuable would be to:

  1. Ensure we have the same features as your readASD function.
  2. Ensure the different versions of ASD files are supported -- a very useful addition would be some unit testing specifically on this.

Thanks!

pierreroudier avatar Mar 08 '21 20:03 pierreroudier