l-qing

Results 65 comments of l-qing

> Thanks @l-qing for this! Would you mind splitting up the PR from refactoring and changing the variable camel cases according to https://github.com/tektoncd/community/blob/main/standards.md#small-pull-requests? Thank you for your suggestion. I've split...

> /lgtm Thank you very much, I was just about to at you for comment. 😆

I once encountered a similar problem, and I suspect it is related to the status "Results were missing" in Phase B. After all, after skipping Phase A, Phase B still...

I'm not sure if this behavior is by design or a bug. Relevant code: https://github.com/tektoncd/pipeline/blob/123f4a211df298ac28dc18df2ec58701c9ffe842/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go#L306-L319 https://github.com/tektoncd/pipeline/blob/123f4a211df298ac28dc18df2ec58701c9ffe842/pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go#L367-L388 https://github.com/tektoncd/pipeline/blob/123f4a211df298ac28dc18df2ec58701c9ffe842/pkg/apis/pipeline/v1/pipelinerun_types.go#L550-L565

This is because your result `build_env_args` wasn't declared as an array type, it was treated as a string type. If you add the declaration of an array type, the execution...

Great! I also faced a similar problem recently. I temporarily set the `Concurrency` of `subscription` to 1, the default is 2.😁 Of course, if it is `update`, it supports more...

> @pierDipi I see. I will make a PR to change `patch` logic to `Update`. 😄 Do you still plan to do this PR?

> @l-qing I think I can make a PR this week. I had no time to handle this issue recently 😭 . Is it an urgent thing for you? It's...

I see this issue can no longer be reproduced on the latest v0.58. Maybe you can try updating to the latest version and see if that helps?