Daniel Cazzulino

Results 360 comments of Daniel Cazzulino

Ha, good catch. Yeah, making the path part of the class structure makes sense. Like `ThisAssembly.Resources.Branding.Icon`. It's perfect :), edited!

Hi @rdeago! Thanks a lot for taking the time to work on this. Looks very promising! I merged a pending PR that did the dotnet-sync update for devlooped/oss, so you...

I just merged all the pending bumps. I'd rather keep this PR clean from those to avoid unrelated noise

Hey @rdeago this has become a monster of a PR. Very very hard to review and wrap my head around. I've been going through the code here and there, but...

Also, I'd use https://www.nuget.org/packages/isexternalinit for that particular polyfill.

> Also (shameless plug ahead) I'm in the course of writing my own - with a different approach (this shouldn't surprise you by now 😁) to prevent code duplication. Long...

> Central package management and folder reorganization are probably the first things to do, so Dependabot PRs and other PRs agree on which files to update. Rebasing after merging of...

Heya @rdeago , thanks a lot for reporting this. I believe as part of your PR for #105 , you had addressed this by checking for a new property that...

Even worse, this isn't even specific to ThisAssembly. I get the same errors with xunit: ``` CSC : error CS2001: Source file '/home/runner/work/ThisAssembly/ThisAssembly/src/ThisAssembly.Tests/.xunit.runner.visualstudio.dotnetcore.testadapter' could not be found. [/home/runner/work/ThisAssembly/ThisAssembly/src/ThisAssembly.Tests/ThisAssembly.Tests.csproj] CSC :...

Yes, I believe things are working again now. Please do reopen if that's not the case.