vuestrap-base-components icon indicating copy to clipboard operation
vuestrap-base-components copied to clipboard

Published 20 hours ago • verified publisher icon kzima

Plan to support Vue2.x and ssr ?

Open LucasIcarus opened this issue 8 years ago • 7 comments

This repo is the best vue-strap components I can find...

Any plan to support vue2.x and server-side-rendering?

Can I pr for a new branch?

LucasIcarus avatar Sep 02 '16 14:09 LucasIcarus

@LucasIcarus Please do :+1:

kzima avatar Sep 07 '16 01:09 kzima

@kzima would this kind of change work for you?

https://github.com/resulto-admin/vuestrap-base-components/commit/41c04affb59c08e3f0fdab97c23c052d1a79143f

Essentially, Vue 2.x deprecated interpolation in attributes and recommend to :class directive instead.

bartdag avatar Oct 04 '16 11:10 bartdag

@LucasIcarus ... indeed +1

tvld avatar Oct 04 '16 14:10 tvld

@bartdag , looks good, much cleaner in html :)

kzima avatar Oct 05 '16 04:10 kzima

Thanks for your feedback. So I have a list of issues I encountered while trying to build vuestrap-base-components. Some of these issues aren't related to vue 2.0 though and may be related to my inexperience with the project.

  • [ ] docs/index.js imports 'vuestrap/components/tags', which is in the master branch of vuestrap but not in 1.0.3. In the meantime, I changed package.json to point to the master branch.
  • [ ] npm run docs raises a scss error about the $dropdown-border-color being undefined in dropdown-override.scss. I temporarily fixed it by adding the variable to src/theme/_docs.scss.
  • [ ] npm run build raises two errors in src/components/compiled.js: it cannot find ./labels and ./pager
  • [ ] Since I can build the docs, I changed the vue js lib in index.html to point to 2.0.1. The page is blank because vue.js raises two errors. The first one is vue.js:2574 [Vue warn]: Do not use built-in or reserved HTML elements as component id: progress.
  • [ ] The second error is vue.js:2574 [Vue warn]: Do not mount Vue to <html> or <body> - mount to normal elements instead.

I can continue to work on individual components, but fixing these errors would help tremendously :-)

bartdag avatar Oct 05 '16 11:10 bartdag

@bartdag , If I was upgrading to vue2.0 I would do one component at a time to help me debug potential issues. Problems 1 and 3 could be that some file's reference is broken. I would check paths to make sure they exists. Problem 2, hmm, sounds like missing variable. Problem 4, please comment out progress component to see if it stops the error. I believe it needs fixing, so it does not use reserved words. Problem 5, please check new docs for vue 2.0 on how to mount Vue to elements.

I hope that helps.

kzima avatar Oct 17 '16 12:10 kzima

does it works with vue 2.x at now?

alexey2baranov avatar Jan 16 '17 06:01 alexey2baranov