fzf-make icon indicating copy to clipboard operation
fzf-make copied to clipboard

Makefile target with variables should be run using variable content

Open Sigmanificient opened this issue 2 years ago • 1 comments

In many Makefiles, rules are defined using make variables. When trying to call such a target, it should use the variable content.

For instance, selecting the $(BUILD_DIR) option should run make .build because make $(BUILD_DIR) is invalid Recipes (rule including a wildcard (%)) should also not appear in the selection menu.

Peek 2023-12-17 05-02

Sigmanificient avatar Dec 17 '23 04:12 Sigmanificient

I'm sorry for the late reply. I haven't have enough time for recent few days.

About a target includes make variables

That's right. I'm sorry but, fzf-make can't execute a target including make variables for now. To resolve this issue, make parser like this can be useful. After resolving some other issues, I will take a time for this problem.

About a target includes wildcard

At first, that the target has only one character is not shown in selection window has been cause by another bug. (https://github.com/kyu08/fzf-make/issues/161) I didn't notice that behavior, thanks for the report!

Apart from that, if my understanding is correct, in order to execute a target including a wildcard, it is necessary to ask the user to specify the content of the wildcard after selecting target. I think it would be good to display an additional modal when a target including a wildcard is selected. I created a issue(https://github.com/kyu08/fzf-make/issues/162) for this enhancement.

kyu08 avatar Jan 01 '24 09:01 kyu08