python-openflow
python-openflow copied to clipboard
kytos
Low level OpenFlow messages parser used by Kytos SDN Platform
``GenericType`` accepts a ``value`` named argument in its initialization that defaults to ``None``. I propose we keep the ``GenericType`` derivatives consistent, naming their initialization argument ``value`` and letting them accept...
ConstantTypeList is never used. TypeList is only used by FixedTypeList, and already behaves as if the list had fixed type. \+ FixedTypeList needs many fixes, specially regarding elements sizes, since...
Many GenericType and GenericStruct derivatives reimplement ``pack(value)`` and ``get_size(value)``, and each one rewrites the code that deals with the ``value`` parameter, as well as the docstring. making GenericType and GenericStruct...
All the GenericStruct unpacks the whole struct. Making GenericMessage only unpack the body makes one structure 'protocol' different from the other, for no reason... PacketIn.unpack() method should be able to...
While implementing ``Match`` and ``ActionSetField`` classes (https://github.com/kytos/python-openflow/issues/348), padding to keep alignment of variable size structs was implemented. I suggest we place the custom ``get_size`` and ``pack`` methods in a new...
GenericStruct __init__ method could accept any named argument that matches a class attribute. This way, derivative classes could have its attributes values initialized on instantiation without having to reimplement __init__...
Message category packages like ``pyof.v0x01.symmetric`` ``__init__`` file could import its submodules classes, so that one is able to do for example: ``from pyof.v0x01.symmetric import Hello`` instead of ``from pyof.v0x01.symmetric.hello import...
Current TestStruct class (tests/test_struct.py) uses unpack method implemented in RawDump class (tests/raw_dump.py) instead of unpack method used when working with the lib. https://github.com/kytos/python-openflow/issues/381 provides one.
Current TestStruct class is only able to test hole messages stored in a dump file. We can recycle it to be able to test any pyof GenericStruct derivative increasing the...
Some attributes need a better understanding regarding it's definition as bitmask or enum or something else: - **common** - **flow_match** - [x] FlowWildCards - is this enum? BitMask? Both? -...
