python-openflow icon indicating copy to clipboard operation
python-openflow copied to clipboard

Possible OF 1.0 Spec error on ofp_port_state

Open diraol opened this issue 8 years ago • 4 comments

On pg.18 of OpenFlow 1.0.0 spec we have the enum ofp_port_state. This is the C++ proposed implementation:

enum ofp_port_state {
    OFPPS_LINK_DOWN = 1 << 0, /* No physical link present. */
    OFPPS_STP_LISTEN = 0 << 8, /* Not learning or relaying frames. */
    OFPPS_STP_LEARN = 1 << 8, /* Learning but not relaying frames. */
    OFPPS_STP_FORWARD = 2 << 8, /* Learning and relaying frames. */
    OFPPS_STP_BLOCK = 3 << 8, /* Not part of spanning tree. */
    OFPPS_STP_MASK = 3 << 8 /* Bit mask for OFPPS_STP_* values. */
}

Its last two options have same values. This appears to be an error, check if it is corrected or compare it with the newer spec versions to understand the expected behaviour.

diraol avatar Apr 26 '16 14:04 diraol