[SQLite Dialect] Properly translate .ignore()

[BitPhinix]

Currently .ignore() using the SQLite dialect gets translated into INSERT IGNORE INTO ....

Which doesn't match the SQLite expected INSERT OR IGNORE INTO (see here)

[igalklebanov]

Hey 👋

Nice catch!

@koskimas I wonder what the solution should be.

The low hangin' fruit is just adding an override in SqliteQueryCompiler that appends an or. The purist in me screams "But it's not WhatYouSeeIsWhatYouGet!!!".

WYSIWYG alternatives are:

db.insertInto('person').or('abort')
db.insertInto('person').or('fail')
db.insertInto('person').or('ignore')
db.insertInto('person').or('replace')
db.insertInto('person').or('rollback')

db.insertInto('person').orAbort()
db.insertInto('person').orFail()
db.insertInto('person').orIgnore()
db.insertInto('person').orReplace()
db.insertInto('person').orRollback()

But having or('ignore') or orIgnore() AND ignore() might be confusing.

[koskimas]

It's not wysiwyg but it's so close that I could live with it.

But supporting all those other or thingies is a good idea, and in that case the separate method(s) is better. I'd go with separate methods.

We might still override ignore to work as well to avoid mistakes?

[igalklebanov]

We might still override ignore to work as well to avoid mistakes?

I definitely think that's the nice thing to do.

[joaobzrr]

Any update on this?