kysely
kysely copied to clipboard
kysely-org
#843 - Use JS sort method to sort migrations by name
Simple fix to #843. Now javascript sort function is used to both sort the executed migrations and the migrations to be executed.
Closes #843
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| kysely | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 21, 2024 10:18am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
This now breaks the sorting by timestamp. Out-of-order migrations can be executed in different order than the name order. That's why the primary ordering is by timestamp.
Then perhaps choose the sort method based on allowUnordered migrations?
Then perhaps choose the sort method based on allowUnordered migrations?
All you need to do is sort using the same logic as the SQL. Sort by timestamp and if the timestamps are equal, sort by name.
@koskimas I will add more tests for the out of order migration because the current tests didn't break when I ordered the executed migrations only by name
@koskimas I've found out why the tests haven't broken with allowUnordereMigrations enabled. The reason was the test migrations name were already in alphabetical order so I've added a test case where the migrations name are not in order to test that when migrating down it determines the migration order using the timestamps.