kysely icon indicating copy to clipboard operation
kysely copied to clipboard

fix: `WithSchemaPlugin` is adding schema to function arguments and causes db errors.

Open igalklebanov opened this issue 1 year ago • 1 comments

Hey :wave:

Recently we've added eb.fn.jsonAgg and eb.fn.toJson. Both accept table names or sql.table/eb.table as arguments.

WithSchemaPlugin adds schema names to the arguments, resulting in DB errors.

This makes the plugin not usable anytime such functions are used, which is quite an annoyance.

This PR makes sure the plugin leaves TableNodes in specific functions' (currently we know of jsonAgg and toJson but there might be more) arguments as-is (no schema is added).

igalklebanov avatar Jan 01 '24 00:01 igalklebanov

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 11:58am

vercel[bot] avatar Jan 01 '24 00:01 vercel[bot]