kysely icon indicating copy to clipboard operation
kysely copied to clipboard

Use kyse.link in kysely.dev homepage instead of the outdated playground it now has

Open GitMurf opened this issue 1 year ago • 3 comments

I am brand new to Kysely and looking to implement in our new sqlite project. I was on the homepage and started playing with the playground on the homepage and noticed orWhere is how to do groupings of OR clauses. I later was looking through the advanced docs and saw reference to the eb.or nomenclature and then stumbled across this PR for the migration to expression builder v2: https://github.com/kysely-org/kysely/pull/565

image

After some investigation I realized the eb.or syntax seemed to be the correct syntax for today and that the home page playground must just be connected to an older version of the API.

To avoid any confusion between the playground and the docs for new users like myself, it would be nice if that playground on the homepage could be updated to the current version / API.

Great product! Looking forward to integrating in our project.

GitMurf avatar Sep 16 '24 23:09 GitMurf

That playground should just be removed. It doesn't use https://kyse.link but some other thing that was thrown together by the person that implemented the first version of kysely.dev.

If you go to the example section, the "correct" playground is used there.

koskimas avatar Sep 17 '24 07:09 koskimas

@koskimas as an fyi I will say it was nice as a new prospective user to have a playground on the homepage. If the correct playground is embeddable then I recommend replacing it, otherwise a link to the playground.

Do you want me to close this issue? Or want to leave it open as a reminder to fix the homepage?

GitMurf avatar Sep 17 '24 11:09 GitMurf

Sorry, I meant we should replace the playground with kyse.link and remove the current one from the codebase. Let's leave this open. I'll rename the issue.

koskimas avatar Sep 17 '24 16:09 koskimas