Foundry-VTT-StarWars-SagaEdition icon indicating copy to clipboard operation
Foundry-VTT-StarWars-SagaEdition copied to clipboard

Data Model enhancement pt1b - npc actors

Open TalonKetupa opened this issue 10 months ago • 1 comments

This is to track the beginnings of migrating data structures to foundry data models. Foundry data models provide the benefits of

validation on initialization and update, and on-the-fly data migration and coercion. It also allows functionality to be delegated out to these models, reducing the burden on the system's Document implementation to solely house such logic https://foundryvtt.com/article/system-data-models/

My current thought for this is to create the base data framework based on the existing way that data is being stored. Also, to transform the data helper/retrieval functions to be separated by the respective document types that use them.

Pt1 will be looking over actors. But I will tackle this one at a time in case there is any feedback in the process. 1a. character actors first - #446 1b. npc actors 1c. vehicle actors - #465 then Pt2 Actor Sheet adjustments Pt3 Data migration and test cases

Create draft of npc data model

  • [x] Initial data scheme and sub groups
  • [x] Draft of helper function changes
  • [x] Validate all data populates in actor correctly
  • [x] Draft changes of sheet handlebars
  • [x] Identify data created by functions that is better served inside the data model
  • [x] Identify redundant/unused/obsolete data
  • [x] Review and reorganize finalized data

This npc data model draft will be temporarily housing transformed versions of helper functions to facilitate a smooth transition when the time comes and also to allow for the data migration functions to be defined at a later time through comparison.

TalonKetupa avatar Apr 20 '24 00:04 TalonKetupa

https://github.com/kypvalanx/Foundry-VTT-StarWars-SagaEdition/issues/465#issuecomment-2078396394

kypvalanx avatar Apr 26 '24 00:04 kypvalanx