Foundry-VTT-StarWars-SagaEdition icon indicating copy to clipboard operation
Foundry-VTT-StarWars-SagaEdition copied to clipboard

[Bug?] Applying Templates

Open LeKopic opened this issue 2 years ago • 8 comments

Not sure if applying templates is already implemented or not, but if they are:

  1. I cannot apply templates to unequipped weapons/armor at all, when I drag and drop - nothing happens. No errors in console either.
  2. When I try to drag and drop template on equipped items - the system sais that I miss the prerequisites. image 2.1) If I try to apply an armor template it lists slightly different prerequisites and I am concerned that it might be requiring both of those prereqs be fullfilled, which is impossible: image

LeKopic avatar May 20 '22 13:05 LeKopic

you currently have to drag them onto the open item windows. open up the item, and drag the template onto it from your inventory. that system was made when items were not allowed to contain items so it contains a workaround. as far as i know, that's still the case.

kypvalanx avatar May 20 '22 14:05 kypvalanx

Ah, ok, I wasn't aware of that. Yeah, after checking it with the method you described - it works.

LeKopic avatar May 20 '22 15:05 LeKopic

i'm reopening this to take a look at making that system more intuitive

kypvalanx avatar May 25 '22 17:05 kypvalanx

Suggestions:

  1. Allow to drag a template to an unopened item + a short instruction somewhere (maybe even the name of the compendium "Templates (drag and drop on item)".
  2. A dedicated button in Equipment screen. image Clicking on it opens a popup window akin to, for example, Weapon Focus feat or Exotic Weapon Proficiency, but it lists all the equipment it can be applied to. Pro - really user-friendly. Con - might be too much to scroll through if there are too many applicable items.
  3. A dedicated button somewhere in item editing screen: image
  4. Or just the same window that asks for an item to be modified as in 2), but on dragging and dropping the template into the equipment tab. image

LeKopic avatar May 25 '22 19:05 LeKopic

currently templates are on the modifications tab, should i rename the tab to "Modifications & Templates" ?

kypvalanx avatar May 26 '22 12:05 kypvalanx

Hm, no, it would take too much space. It can be done as a completely separate category in Modifications tab though. Something along those lines, maybe? image

Also, do standard upgrades work? I am unable to apply Trageting Scopes or any other available upgrades + some upgrades are just missing from Items compendium.

LeKopic avatar May 26 '22 17:05 LeKopic

Also, do standard upgrades work? I am unable to apply Trageting Scopes or any other available upgrades + some upgrades are just missing from Items compendium.

templates got TLC recently, i didn't touch standard mods. sounds like something to do over the long weekend

kypvalanx avatar May 27 '22 14:05 kypvalanx

how this currently works is that a template has to be added to an actor first, and then applied to a given item on that sheet. the problem is that items that are not on an actor, cannot be modified in this way.

items can accept ActiveEffects. i will be modifying the ondrop method for items onto items to create an equivalent activeEffect rather than a link to an item on a parent sheet. this should do quite a bit to simplify code and make it possible to modify unaffiliated items.

kypvalanx avatar Apr 08 '23 03:04 kypvalanx