Node data is not deleted when bob wallet is uninstalled on windows 10

[fuomag9]

Node data is not deleted when bob wallet is uninstalled. I'm using version 0.4.0

Expected Behavior

%AppData%\Roaming\Bob should not exist after bob wallet is uninstalled

Current Behavior

%AppData%\Roaming\Bob remains on the system and uses space with full node data in it

Steps to Reproduce

1. Install bob wallet
2. Make it sync a bit and verify that data is being saved in %AppData%\Roaming\Bob
3. Uninstall it
4. %AppData%\Roaming\Bob will not be deleted

Context (Environment)

A non dev user will be not aware that node data will be still occupying space on his sistem, and on computers with low space or when the blockchain will grow in size this can be a serious issue

[sdtsui]

Great catch, thank you.

[sdtsui]

Updated the 0.6.0 release notes to link to this issue. Will update general instructions as well at around the next stable release.

[rithvikvibhu]

Not removing blockchain data (hsd_data) is currently the standard behavior across all platforms.

Should we be deleting it on uninstall?

Personally, I would say no, because after updating Bob to a new version, a user would normally uninstall the previous one, and would expect to not download everything again.

[fuomag9]

Not removing blockchain data (hsd_data) is currently the standard behavior across all platforms.

Should we be deleting it on uninstall?

Personally, I would say no, because after updating Bob to a new version, a user would normally uninstall the previous one, and would expect to not download everything again.

Then it should be made as an optional parameter during the uninstall process (or do the reverse and disable it during the uninstall made by the update process) since blockchain data takes space and when an user uninstalls bob-wallet he'll probably expect not to have data left on the system made by the program. (Or at least not data that takes considerable amounts of space)