nbstripout icon indicating copy to clipboard operation
nbstripout copied to clipboard

Fix Windows tests

Open kynan opened this issue 8 years ago • 2 comments

Tests are currently failing on Windows due to cram not unifying line endings, see brodie/cram#9.

kynan avatar Sep 21 '16 23:09 kynan

I've tried to use cram myself for a project and got bitten by this.

This commit https://github.com/zertrin/nbstripout/commit/920bb050220666818c8feb4bacbd57815fbc1dbe tries to minimize the problem but doesn't solve it... Lines with options like (re) can't be fixed by the core.autocrlf trick.

My conclusion at this point is that cram is not usable on windows. I have dropped it from my project since a look at their issue tracker and git activity shows that the project is not gonna fix this anytime soon.

zertrin avatar Mar 30 '17 12:03 zertrin

@zertrin thanks for looking into this. Great idea using core.autocrlf, I'll apply that change anyway, even though it doesn't fix it.

The only solution at this point is probably forking cram until @brodie picks up the project again.

kynan avatar May 18 '17 06:05 kynan

https://github.com/brodie/cram hasn't had a release since 2016 and is now archived. It's probably easier to port the tests to another framework than to fix/update/fork/whatever cram.

arobrien avatar Nov 12 '22 05:11 arobrien

Yes, that's what I'm intending to do. See #165.

kynan avatar Nov 12 '22 19:11 kynan

@arobrien interested to help with this?

kynan avatar Nov 12 '22 19:11 kynan