kyma icon indicating copy to clipboard operation
kyma copied to clipboard

Use semantic versioning for kyma modules (managers)

Open pbochynski opened this issue 1 year ago • 10 comments

Description

According to the modularization concept modules artifacts should use semantic versioning (semver.org). This requirement was fulfilled by the front runners modules, but is not consequently applied by other modules. Here are the latest released versions of module managers (operators):

  • [x] europe-docker.pkg.dev/kyma-project/prod/istio-manager:1.1.2
  • [x] europe-docker.pkg.dev/kyma-project/prod/api-gateway-manager:2.0.0
  • [x] europe-docker.pkg.dev/kyma-project/prod/serverless-operator:1.4.3
  • [x] europe-docker.pkg.dev/kyma-project/prod/btp-manager:1.0.1
  • [x] europe-docker.pkg.dev/kyma-project/prod/telemetry-manager:v20231106-2bbe91ce (https://github.com/kyma-project/telemetry-manager/issues/566)
  • [x] europe-docker.pkg.dev/kyma-project/prod/nats-manager:3aee6dc4bd47f62c72caf19557d717e8c2706527
  • [x] europe-docker.pkg.dev/kyma-project/prod/eventing-manager:49b1192071ec05bfdd18c1f667544ac34aa927a1
  • [x] europe-docker.pkg.dev/kyma-project/prod/application-connector-manager:v20231106-bfc94e9f
  • [x] europe-docker.pkg.dev/kyma-project/prod/keda-manager:1.0.0

Expected result All modules use semantic versioning

Actual result

Steps to reproduce

Troubleshooting

pbochynski avatar Nov 15 '23 19:11 pbochynski

@koala7659, @m00g3n, I thought that we already switched to semver with 1.0.3. Could you have a look?

Disper avatar Nov 16 '23 06:11 Disper

@pbochynski We use semantic versioning for application-connector-module. Version 1.0.3 is available in both fast and regular channel

koala7659 avatar Nov 16 '23 09:11 koala7659

@pbochynski could you elaborate where the ACM is not using semver?

  • We have switched to the 1.0.3 release tag
  • In the Kyma Dashboard the 1.0.3 version is available image

Disper avatar Nov 16 '23 09:11 Disper

@Disper When you look into the released deployment you can find that the operator is in version:

europe-docker.pkg.dev/kyma-project/prod/application-connector-manager:v20231106-bfc94e9f

If you want to check which version is applied in your cluster you have to download the yaml file from release artifacts and check what is inside. If the version matches your deployment then you know the version. Wouldn't it be easier if you follow the pattern we established with the modularization front runners (keda, btp-manager, serverless) and use semantic versioning for module manager?

pbochynski avatar Nov 17 '23 07:11 pbochynski

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 06 '24 00:05 github-actions[bot]

@Disper application-connector-manager is still not following that convention

a-thaler avatar May 06 '24 07:05 a-thaler

@a-thaler : we will pick it up as part of our release process automation and fix it in coming sprint(s). Have to see how fast we can implement the process, but we have it on the radar. Issue for release process automation is https://github.com/kyma-project/application-connector-manager/issues/104.

tobiscr avatar May 07 '24 11:05 tobiscr

fix for ACM ready, see:

https://console.cloud.google.com/artifacts/docker/kyma-project/europe/prod/application-connector-manager/sha256:039b081aa205dc66e8d7b6a9176c85dcbcb536facf0b382275aabbf5692e26af

tobiscr avatar Jun 17 '24 13:06 tobiscr

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 18 '24 00:08 github-actions[bot]