kyma icon indicating copy to clipboard operation
kyma copied to clipboard

Improve consumer logic, add unit tests

Open vpaskar opened this issue 2 years ago • 2 comments

Description

Changes proposed in this pull request:

  • pack all the consumer login into one function splitted into blocks
  • add unit test using mocks
  • add errors package

Related issue(s)

vpaskar avatar Oct 10 '22 09:10 vpaskar

🥰 Documentation preview ready! 🥰

Name Link
Latest commit 7fb5dbfd48bfb33bedf864b9ab17d8306439275f
Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/634fba40c1e1230008344dea
Deploy Preview https://deploy-preview-15762--kyma-project-docs-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 12 '22 08:10 netlify[bot]

/test pre-main-kyma-gardener-gcp-eventing /test pre-main-kyma-gardener-gcp-eventing-upgrade

vpaskar avatar Oct 17 '22 09:10 vpaskar

/hold

vpaskar avatar Oct 18 '22 14:10 vpaskar

/test-all

vpaskar avatar Oct 19 '22 07:10 vpaskar

/test-all

vpaskar avatar Oct 19 '22 08:10 vpaskar

@VladislavPaskar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-protecode-guard 83f60737382873473c0394a72381d6be1145356f link false /test pre-main-kyma-protecode-guard
pre-main-kyma-skr-eventing fb4dfa8a775476676e065c4e82537eb004d240fc link false /test pre-main-kyma-skr-eventing

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kyma-bot avatar Oct 19 '22 13:10 kyma-bot