kyma icon indicating copy to clipboard operation
kyma copied to clipboard

rename remaining test files in `event-publisher-proxy`

Open friedrichwilken opened this issue 2 years ago • 9 comments

renamed all remaining test files from _test.go to _unit_test.go or integration_test.go accordingly. All test files in event-publisher-proxy should follow this naming pattern now.

friedrichwilken avatar Oct 04 '22 08:10 friedrichwilken

/retest

friedrichwilken avatar Oct 04 '22 09:10 friedrichwilken

/test pre-main-kyma-gardener-gcp-eventing-upgrade

friedrichwilken avatar Oct 05 '22 09:10 friedrichwilken

whats the difference between integration test and component test?

raypinto avatar Oct 05 '22 10:10 raypinto

@raypinto the handler_health_test.go in both are renamed to handler_health_unit_test.go because they indeed do the same. however health_test.go in nats was renamed to health_interation_test.go. I gave it another look and I agree, this is a unit test. so I just changed it to health_unit_test.go.

friedrichwilken avatar Oct 05 '22 11:10 friedrichwilken

/test pre-main-kyma-gardener-gcp-eventing-upgrade

friedrichwilken avatar Oct 05 '22 12:10 friedrichwilken

New changes are detected. LGTM label has been removed.

kyma-bot avatar Oct 05 '22 17:10 kyma-bot

/retest

friedrichwilken avatar Oct 06 '22 06:10 friedrichwilken

This is blocked for now, since #15672 might do the same things anyhow.

friedrichwilken avatar Oct 14 '22 08:10 friedrichwilken

/retest

friedrichwilken avatar Oct 18 '22 14:10 friedrichwilken

@friedrichwilken: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-skr-eventing 4d7228a1f661f99aaaae82363f8578fd384b4d3b link false /test pre-main-kyma-skr-eventing

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kyma-bot avatar Oct 18 '22 14:10 kyma-bot