kyma icon indicating copy to clipboard operation
kyma copied to clipboard

Make JetStream tests use test doubles instead of a real NATS server

Open raypinto opened this issue 2 years ago • 1 comments

Description

All the tests in the JetStream handler start a full blown NATS server. Change this behaviour to use the server when its really needed and use test doubles for the other tests.

Reasons

Improve tests and make it as efficient as possible.

Implementation

  • [ ] #15705
  • [ ] #15706

raypinto avatar Sep 27 '22 09:09 raypinto

2 steps

  • [ ] write unit tests for every function in jetstream backend. (5)
  • [ ] move all existing integration tests from backend tests to reconciler tests.

k15r avatar Oct 04 '22 09:10 k15r

This issue or PR has been automatically marked as stale due to the lack of recent activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

kyma-bot avatar Feb 19 '23 11:02 kyma-bot

This issue or PR has been automatically closed due to the lack of activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

kyma-bot avatar Feb 26 '23 11:02 kyma-bot

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity. Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyma-bot avatar Feb 26 '23 11:02 kyma-bot